endigma/gpu-screen-recorder
1
0
Fork 0
Code Issues Pull requests 1 Activity Actions

sdasdasd #3

Open
endigma wants to merge 2 commits from proposed/streaming-sinks into upstream
pull from: proposed/streaming-sinks
merge into: endigma:upstream
Conversation 2 Commits 2 Files changed 1 +28 -14
endigma commented 2026-05-10 12:31:38 +01:00
Owner
Copy link

asdasdasdwqefewrfgqvqwecwef

asdasdasdwqefewrfgqvqwecwef
Upstream now permits opus with mpegts (.ts). Extend the same allow-list
to .flv so opus survives publishing to a flv/rtmp sink. ffmpeg's flv
muxer (Enhanced RTMP) carries opus directly. Without this, anyone
publishing to a sink like MediaMTX over RTMP gets silently downgraded
to aac — which then can't be carried over WebRTC on the playback side
(WebRTC's standard payload set is opus/g711/pcm only, no aac).
`-c rtsp -o "rtsp://..."` previously failed with "Protocol not found"
because gsr unconditionally called avio_open() on the URL. avio_open
looks up "rtsp" as an avio protocol — but rtsp is a *format/muxer*,
not a protocol. The rtsp muxer (and friends like rtp/sap/sdp) sets
AVFMT_NOFILE and manages its own RTP-over-tcp/udp transport inside
avformat_write_header.

This is the standard ffmpeg pattern; see ffmpeg.c which gates
avio_open on `!(oformat->flags & AVFMT_NOFILE)`. Apply the same gate
to all four call sites in gsr (and the matching avio_close at three
cleanup sites), so URL muxers like rtsp work without a "Protocol not
found" error.

Verified with a live `-k hevc -ac opus -c rtsp -o rtsp://...` round-trip
into MediaMTX; tracks come up as H265+Opus over RTP/UDP.
endigma commented 2026-05-10 15:50:01 +01:00
Author
Owner
Copy link

!draft

!draft
👀 1
forgejo-actions commented 2026-05-10 15:50:29 +01:00
Copy link

📋 Draft for PATCH

field value
Subject [PATCH] sdasdasd
To (unset — set PATCH_TO_ADDRESS variable)
From endigma <endigma@mailcat.ca>
Message-Id <177842462775.627.4242746618074917749@mailcat.ca>
Attachments 1 .patch file(s)
Cover letter body 
asdasdasdwqefewrfgqvqwecwef
Attached patches (1)
  • 0001-sdasdasd.patch

Comment !send to dispatch this draft via SMTP. Workflow run.

(updated 2026-05-10T14:50:29Z)

<!-- send.yml:draft --> ### 📋 Draft for `PATCH` | field | value | |---|---| | Subject | `[PATCH] sdasdasd` | | To | `(unset — set PATCH_TO_ADDRESS variable)` | | From | `endigma <endigma@mailcat.ca>` | | Message-Id | `<177842462775.627.4242746618074917749@mailcat.ca>` | | Attachments | 1 .patch file(s) | <details><summary>Cover letter body</summary> ``` asdasdasdwqefewrfgqvqwecwef ``` </details> <details><summary>Attached patches (1)</summary> - `0001-sdasdasd.patch` </details> --- Comment `!send` to dispatch this draft via SMTP. [Workflow run](https://forge.gitcat.ca/endigma/gpu-screen-recorder/actions/runs/20). _(updated 2026-05-10T14:50:29Z)_
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin proposed/streaming-sinks:proposed/streaming-sinks
git switch proposed/streaming-sinks
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
send
No labels
send
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
endigma/gpu-screen-recorder!3
No description provided.